[
https://issues.apache.org/jira/browse/KNOX-3065?focusedWorklogId=942943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-942943
]
ASF GitHub Bot logged work on KNOX-3065:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/24 00:25
Start Date: 10/Nov/24 00:25
Worklog Time Spent: 10m
Work Description: pzampino commented on code in PR #947:
URL: https://github.com/apache/knox/pull/947#discussion_r1835551973
##########
gateway-spi/src/main/java/org/apache/knox/gateway/SpiGatewayMessages.java:
##########
@@ -123,4 +123,19 @@ public interface SpiGatewayMessages {
@Message( level = MessageLevel.ERROR, text = "No valid principal found" )
void noPrincipalFound();
+
+ @Message( level = MessageLevel.INFO, text = "Every event was read from the
SSE stream" )
+ void sseConnectionDone();
+
+ @Message( level = MessageLevel.ERROR, text = "Error during SSE connection:
{0}" )
+ void sseConnectionError(String error);
+
+ @Message( level = MessageLevel.ERROR, text = "Error writing into the SSE
output stream : {1}" )
Review Comment:
Shouldn't {1} be {0} here?
Issue Time Tracking
-------------------
Worklog Id: (was: 942943)
Time Spent: 2h 40m (was: 2.5h)
> Support Server Sent Events (SSE) in Knox
> ----------------------------------------
>
> Key: KNOX-3065
> URL: https://issues.apache.org/jira/browse/KNOX-3065
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 2.1.0
> Reporter: Tamás Hanicz
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently Knox is not working with SSE. In case of SSE the response header
> contains Content-Type = text/event-stream, in which case the server will send
> messages terminated by \n\n. Knox should send these messages to the client as
> they arrive. Currently Knox collects them all, and once the server closes the
> connection sends all of them concatenated to each other to the client.
> Requirement:
> * Full support in Knox for Server Sent Events.
> Definition of done:
> * Clients can connect to SSE endpoints in the backend via Knox.
> * Server Sent Events
> ([https://html.spec.whatwg.org/multipage/server-sent-events.html#server-sent-events])
> are forwarded by Knox from the server to the client as soon as they are
> received.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
