hanicz commented on code in PR #995:
URL: https://github.com/apache/knox/pull/995#discussion_r1971346237
##########
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/JettySSLService.java:
##########
@@ -236,6 +236,17 @@ public Object buildSslContextFactory(GatewayConfig config)
throws AliasServiceEx
return sslContextFactory;
}
+ @Override
+ public void excludeTopologyFromClientAuth(SslContextFactory
sslContextFactory, GatewayConfig config, String topologyName) {
+ if(config.getClientAuthExclude() != null && topologyName != null
+ && config.isClientAuthNeeded() &&
config.getClientAuthExclude().contains(topologyName)) {
Review Comment:
Nice catch, I moved the exclude related checks into the GatewayConfigImpl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
