smolnar82 commented on code in PR #995:
URL: https://github.com/apache/knox/pull/995#discussion_r1971433548
##########
gateway-server/src/test/java/org/apache/knox/gateway/GatewayGlobalConfigTest.java:
##########
@@ -67,11 +69,20 @@ public void testSiteConfig() {
GatewayConfig config = new GatewayConfigImpl();
assertThat( config.getGatewayPort(), is( 5555 ) );
assertThat( config.isClientAuthNeeded(), is( true ) );
+ assertTrue( config.isTopologyExcludedFromClientAuth("health"));
assertThat( config.getTruststorePath(), is("./gateway-trust.jks"));
assertThat( config.getTruststoreType(), is( "PKCS12" ) );
assertThat( config.getKeystoreType(), is(KeyStore.getDefaultType()) );
}
+ @Test
+ public void testSiteConfigWithDifferentTopologyExcluded() {
+ System.setProperty( GatewayConfigImpl.GATEWAY_HOME_VAR, getHomeDirName(
"conf-site/conf/gateway-site.xml" ) );
+ GatewayConfig config = new GatewayConfigImpl();
+ assertThat( config.isClientAuthNeeded(), is( true ) );
Review Comment:
nit: `assertTrue` might have been better, but doesn't prevent the merge
this as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
