cxm940188 commented on code in PR #1015: URL: https://github.com/apache/knox/pull/1015#discussion_r2030830003
########## gateway-server/src/test/java/org/apache/knox/gateway/services/security/impl/DefaultKeystoreServiceTest.java: ########## @@ -814,7 +815,7 @@ private GatewayConfigImpl createGatewayConfig(Path baseDir) { } - private void createKeystore(DefaultKeystoreService keystoreService, Path keystoreFilePath, String alias, char[] password) + private void createKeystore(DefaultKeystoreService keystoreService, Path keystoreFilePath, String alias, char[] password, String selfSigningAlgorithm) Review Comment: Thanks. I will make changes based on your feedbacks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org