cxm940188 commented on code in PR #1015:
URL: https://github.com/apache/knox/pull/1015#discussion_r2030830550
##########
gateway-spi/src/main/java/org/apache/knox/gateway/config/GatewayConfig.java:
##########
@@ -92,6 +92,8 @@ public interface GatewayConfig {
String CREDENTIAL_STORE_ALG = "gateway.credential.store.alg";
String DEFAULT_CREDENTIAL_STORE_ALG = "AES";
+ String CREDENTIAL_SELF_SIGNING_ALG = "gateway.credential.self-signing.alg";
Review Comment:
reply:
- For the first comment, I will make changes based on your suggestions.
- For the second point, I feel that the` gateway.self.signing.cert.alg`
property doesn't seem better than `gateway.credential.self.signing.alg` . Of
course, this is my personal opinion. Whether to modify it or not, I hope you
can help me make a final choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
