moresandeep commented on PR #1043:
URL: https://github.com/apache/knox/pull/1043#issuecomment-2892159271
Following are the major changes in `CommonIdentityAssertionFilter` class
- Centralized “is impersonation enabled” logic
• Old: read IMPERSONATION_ENABLED_PARAM directly from
filterConfig, parsed its boolean value inline
• New: delegated that check to a new helper
- Eliminated duplicate constant
• Removed the class-local static final String
IMPERSONATION_ENABLED_PARAM = AuthFilterUtils.PROXYUSER_PREFIX +
".impersonation.enabled";
• Instead statically import
AuthFilterUtils.IMPERSONATION_ENABLED_PARAM (and added
GROUP_IMPERSONATION_ENABLED_PARAM for future use)
- Helper methods promoted & grouped
• Moved virtualGroupParameterNames(...) and unique(...) up near
the top of the class, declared them private static so all utility logic is
visible before the lifecycle methods.
- No other behavior changes
• All the parsing of advanced principal mappings, virtual-group
loading, doFilter flow, etc., is untouched—only how and where the impersonation
flag is determined was refactored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
