moresandeep commented on PR #1043: URL: https://github.com/apache/knox/pull/1043#issuecomment-2892161299
**Note**: _The following summary is generated using co-pilot_ This pull request refactors the `CommonIdentityAssertionFilter` class and its related tests to improve code maintainability, readability, and functionality. Key changes include the introduction of a new method for checking impersonation provider requirements, reorganization of imports, and updates to test cases to align with the refactored implementation. ### Refactoring and Code Simplification: * Introduced the `shouldAddImpersonationProvider` method to encapsulate logic for determining if the impersonation provider should be added, replacing inline checks. (`[gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/CommonIdentityAssertionFilter.javaR170-R180](diffhunk://#diff-4577bd8f7a7a8aa491f44533f5111e9deb9496962b2059d5e0cbb3f1b59c4bfdR170-R180)`) * Removed redundant methods `virtualGroupParameterNames` and `unique`, and integrated their functionality directly where needed. (`[[1]](diffhunk://#diff-4577bd8f7a7a8aa491f44533f5111e9deb9496962b2059d5e0cbb3f1b59c4bfdL207-L211)`, `[[2]](diffhunk://#diff-4577bd8f7a7a8aa491f44533f5111e9deb9496962b2059d5e0cbb3f1b59c4bfdL299-R312)`) * Reorganized imports in `CommonIdentityAssertionFilter` to improve clarity and remove unused dependencies. (`[[1]](diffhunk://#diff-4577bd8f7a7a8aa491f44533f5111e9deb9496962b2059d5e0cbb3f1b59c4bfdL20-L46)`, `[[2]](diffhunk://#diff-4577bd8f7a7a8aa491f44533f5111e9deb9496962b2059d5e0cbb3f1b59c4bfdL65-R90)`) ### Test Case Updates: * Updated test cases in `CommonIdentityAssertionFilterTest` to use the refactored `shouldAddImpersonationProvider` method and replaced references to the removed `IMPERSONATION_ENABLED_PARAM` constant. (`[[1]](diffhunk://#diff-f1e853cfe04089b2ce1381bc562b0d6e96ace1db5ee2c0085fa1dd8bdaaae7dfL286-R264)`, `[[2]](diffhunk://#diff-f1e853cfe04089b2ce1381bc562b0d6e96ace1db5ee2c0085fa1dd8bdaaae7dfL141-R141)`) * Reorganized imports in `CommonIdentityAssertionFilterTest` for consistency with the refactored implementation. (`[[1]](diffhunk://#diff-f1e853cfe04089b2ce1381bc562b0d6e96ace1db5ee2c0085fa1dd8bdaaae7dfL20-R40)`, `[[2]](diffhunk://#diff-f1e853cfe04089b2ce1381bc562b0d6e96ace1db5ee2c0085fa1dd8bdaaae7dfL41-R60)`) * Added expectations for new impersonation-related parameters in `HadoopAuthFilterTest` to ensure compatibility with the updated implementation. (`[[1]](diffhunk://#diff-856be9bd8db07e7ffa4042e3f2943b254b2c6204e1bd7e50c6bfae8fa89e3cf3R148-R149)`, `[[2]](diffhunk://#diff-856be9bd8db07e7ffa4042e3f2943b254b2c6204e1bd7e50c6bfae8fa89e3cf3R214-R215)`, `[[3]](diffhunk://#diff-856be9bd8db07e7ffa4042e3f2943b254b2c6204e1bd7e50c6bfae8fa89e3cf3R266-R267)`, `[[4]](diffhunk://#diff-856be9bd8db07e7ffa4042e3f2943b254b2c6204e1bd7e50c6bfae8fa89e3cf3R329-R330)`, `[[5]](diffhunk://#diff-856be9bd8db07e7ffa4042e3f2943b254b2c6204e1bd7e50c6bfae8fa89e3cf3R392-R393)`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
