[
https://issues.apache.org/jira/browse/KNOX-3146?focusedWorklogId=970310&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-970310
]
ASF GitHub Bot logged work on KNOX-3146:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/25 09:02
Start Date: 22/May/25 09:02
Worklog Time Spent: 10m
Work Description: hanicz opened a new pull request, #1049:
URL: https://github.com/apache/knox/pull/1049
## What changes were proposed in this pull request?
This PR builds on [PR-947](https://github.com/apache/knox/pull/947) and
[PR-1010](https://github.com/apache/knox/pull/1010). It completes the SSE
feature by adding the failover capability to the HA dispatch.
- Fixed a bug where service connection error wasn't sent to the client for
non HA
- Renamed `LBHaDispatch` -> `CommonHaDispatch` since it holds failover logic
as well now
- Moved failover logic from `ConfigurableHaDispatch` to `CommonHaDispatch`
to avoid code duplication
- Added failover for `SSEHaDispatch`
- New tests for SSE HA to cover the new failover capability
- Moved `httpcore` dependency exclusions to the parent pom level
## How was this patch tested?
Unit tests
Manual tests
Local setup:
I had a custom SSE service running locally.
```
<provider>
<role>ha</role>
<name>HaProvider</name>
<enabled>true</enabled>
<param>
<name>SSERVICE</name>
<value>
maxFailoverAttempts=3;failoverSleep=1000;enableStickySession=true;enabled=true;enableLoadBalancing=true;noFallback=true
</value>
</param>
<param>
<name>HUE</name>
<value>
enableStickySession=true;enabled=true;enableLoadBalancing=true;maxFailoverAttempts=1;failoverSleep=1000
</value>
</param>
</provider>
<service>
<role>HUE</role>
<url>http://localhost3:7435</url>
<url>http://localhost:7435</url>
<url>http://localhost2:7435</url>
<url>http://localhost1:7435</url>
<url>http://localhost5:7435</url>
</service>
<service>
<role>SSERVICE</role>
<url>http://localhost3:7435</url>
<url>http://localhost:7435</url>
<url>http://localhost2:7435</url>
<url>http://localhost1:7435</url>
<url>http://localhost5:7435</url>
</service>
```
`curl -k -i -u admin:admin-password
https://localhost:8443/gateway/mytopology/hue/sse`
`curl -k -i -u admin:admin-password
https://localhost:8443/gateway/mytopology/sservice/sse`
Issue Time Tracking
-------------------
Worklog Id: (was: 970310)
Remaining Estimate: 0h
Time Spent: 10m
> Failover ability for SSEHaDispatch
> ----------------------------------
>
> Key: KNOX-3146
> URL: https://issues.apache.org/jira/browse/KNOX-3146
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 2.2.0
> Reporter: Tamás Hanicz
> Assignee: Tamás Hanicz
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The failover ability is missing for SSEHaDispatch. It would be beneficial to
> add it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
