[
https://issues.apache.org/jira/browse/KNOX-3146?focusedWorklogId=972108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-972108
]
ASF GitHub Bot logged work on KNOX-3146:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/25 13:08
Start Date: 06/Jun/25 13:08
Worklog Time Spent: 10m
Work Description: hanicz commented on code in PR #1049:
URL: https://github.com/apache/knox/pull/1049#discussion_r2132166761
##########
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/SSEHaDispatch.java:
##########
@@ -136,17 +149,100 @@ public void setActiveURL(String url) {
activeURL.set(url);
}
+ @Override
+ public int getMaxFailoverAttempts() {
+ return maxFailoverAttempts;
+ }
+
+ @Override
+ public void setMaxFailoverAttempts(int maxFailoverAttempts) {
+ this.maxFailoverAttempts = maxFailoverAttempts;
+ }
+
+ @Override
+ public int getFailoverSleep() {
+ return failoverSleep;
+ }
+
+ @Override
+ public void setFailoverSleep(int failoverSleep) {
+ this.failoverSleep = failoverSleep;
+ }
+
+ @Override
+ public void setFailoverNonIdempotentRequestEnabled(boolean enabled) {
+ this.failoverNonIdempotentRequestEnabled = enabled;
+ }
+
+ @Override
+ public boolean isFailoverNonIdempotentRequestEnabled() {
+ return failoverNonIdempotentRequestEnabled;
+ }
+
+ @Override
+ public void setNoFallbackEnabled(boolean enabled) {
+ this.noFallbackEnabled = enabled;
+ }
+
+ @Override
+ public boolean isNoFallbackEnabled() {
+ return noFallbackEnabled;
+ }
+
Review Comment:
Yes, that is the reason. We could move them into `ConfigurableDispatch` or
`DefaultDispatch`. However I don't think we should add HA code to non HA
Dispatches.
Issue Time Tracking
-------------------
Worklog Id: (was: 972108)
Time Spent: 0.5h (was: 20m)
> Failover ability for SSEHaDispatch
> ----------------------------------
>
> Key: KNOX-3146
> URL: https://issues.apache.org/jira/browse/KNOX-3146
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 2.2.0
> Reporter: Tamás Hanicz
> Assignee: Tamás Hanicz
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The failover ability is missing for SSEHaDispatch. It would be beneficial to
> add it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
