I tried reverting it and it still failed. Furthermore, I tried a Maven clean/test/verify from 1.7.0 with a binDir set to 1.7.1-RC1’s release build and it still failed. The same Maven build with 1.7.0’s release build failed too now though, so it seems this is either a flaky test, or more likely me messing up my builds in a way that looked like it’s a regression introduced in 1.7.1…
Anyway, I’ll try to figure out what this is about later, but as it seems it’s not something 1.7.1 introduced after all, I’m back to +1, non-binding. > On 2018. May 9., at 20:48, Todd Lipcon <t...@cloudera.com> wrote: > > Hm, that's interesting. KUDU-2379 is the only one I can think of that might > have caused this issue. If you revert that change, does it fix the test? > > On Wed, May 9, 2018 at 11:46 AM, Attila Bukor <abu...@cloudera.com> wrote: > >> Hi Todd, >> >> Yes, Kudu Client tests all pass on 1.7.0 (although I tried it only once) >> and it fails consistently on 1.7.1-RC1. Also I’m not convinced this would >> be a test-only issue as none of these changes seem to have touched the >> tests between the releases: >> >> $ git log --oneline 1.7.0..1.7.1-RC1 -- java >> ffc01ab72 (tag: 1.7.1-RC1) Bump version to 1.7.1 (non-SNAPSHOT) >> f357fc211 java: fix a mistaken reference-equality check for BigDecimal >> predicates >> 1e49ac8a9 KUDU-2416: Fix PartialRow.setMin and add a unit test >> 608b5a3d3 KUDU-2379. java: exportAuthenticationCredentials must connect >> to the cluster >> 3d113b9b3 Bump version to 1.7.1-SNAPSHOT >> >> Attila >> >> On 2018. May 9., at 20:13, Todd Lipcon <t...@cloudera.com> wrote: >> >> Hey Attila, >> >> Is this a regression from 1.7.0 for you? If not, I don't think it should >> block the maintenance release. We can always do more maintenance releases >> to address further bugs. >> >> Additionally my guess is this is a test-only issue since ITClientStress >> does some strange stuff reaching into Netty internals. >> >> -Todd >> >> On Wed, May 9, 2018 at 10:52 AM, Attila Bukor <abu...@cloudera.com> wrote: >> >> I made a mistake and ran the Java tests agains another binDir. With >> 1.7.1-RC1 release build I actually have a Kudu Java Client error: >> >> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 61.261 sec >> - in org.apache.kudu.client.ITClient >> >> Results : >> >> Failed tests: >> ITClientStress.testManyShortClientsGeneratingScanTokens:99->runTasks:76 >> org.jboss.netty.channel.ChannelException: Failed to create a selector. >> >> Tests in error: >> ITClientStress.testMultipleSessions:134 ? Channel Failed to create a >> selector. >> >> I think this should be addressed in 1.7.1, so I guess this makes it a -1, >> although still non-binding of course. >> >> Attila >> >> On 2018. May 9., at 18:03, Attila Bukor <abu...@cloudera.com> wrote: >> >> +1 (non-binding) >> >> Built on CentOS 7.3 in release mode as well. I had one C++ test failure >> >> when I built this with Ninja due to it running "which ninja" and on this >> machine it's called ninja-build. I was able to work around it by adding a >> symlink called ninja to the $PATH, that way the actual tests passed too. As >> Ninja is experimental, this is not a problem. >> >> >> mvn test verify in java/ succeeded without failures though. >> >> >> On 2018. May 9., at 17:30, Andrew Wong <aw...@apache.org> wrote: >> >> +1 >> >> I built on CentOS 7.3 and ran all C++ tests in release mode and with >> >> TSAN. >> >> All passed. >> >> On Wed, May 9, 2018 at 12:08 AM, Mike Percy <mpe...@apache.org> wrote: >> >> I hit that issue too, but running >> >> unset GLOG_colorlogtostderr >> >> Made those tests pass for me as well. >> >> Mike >> >> Sent from my iPhone >> >> On May 8, 2018, at 11:40 PM, Alexey Serbin <aser...@cloudera.com> >> >> wrote: >> >> >> +1 >> >> I built 1.7.1 RC1 (release) on CentOS 6.6. >> >> All C++ tests passed except for the following ones: >> >> ToolTest.TestTopLevelHelp >> ToolTest.TestModeHelp >> ToolTest.TestActionHelp >> ToolTest.TestActionMissingRequiredArg >> >> However, I don't think it's an issue that should block the release (I >> >> hope to have some time to a look at the breakages soon). >> >> >> Thank you very much for taking care of the release management for >> >> 1.7.1, >> >> Grant! >> >> >> >> >> Kind regards, >> >> Alexey >> >> >> >> On 5/8/18 2:06 PM, Hao Hao wrote: >> +1 >> >> * Release note looks good >> * Built in Debug/release mode on el7, all tests passed. >> >> Best, >> Hao >> >> On Tue, May 8, 2018 at 8:59 AM, Mike Percy <mpe...@apache.org> >> >> wrote: >> >> >> +1 >> >> * Release notes look good >> * Tag matches archive >> * LICENSE file looks fine >> * Built in release mode on Ubuntu 16.04, all tests passed >> >> Thanks for managing the release, Grant! >> >> Mike >> >> On Wed, May 2, 2018 at 2:44 PM, Grant Henke <ghe...@cloudera.com> >> >> wrote: >> >> >> Hi, >> >> The Apache Kudu team is happy to announce the first release >> >> candidate >> >> for >> >> Apache Kudu 1.7.1. >> >> Apache Kudu 1.7.1 is a bug-fix release which fixes critical issues >> >> in >> >> Kudu >> >> 1.7.0. >> >> The is a source-only release. The artifacts have been staged here: >> https://dist.apache.org/repos/dist/dev/kudu/1.7.1-RC1/ >> >> Java convenience binaries in the form of a Maven repository are >> >> staged >> >> here: >> https://repository.apache.org/content/repositories/ >> >> orgapachekudu-1020/ >> >> >> It is tagged in Git as 1.7.1-RC1 and the corresponding git hash is >> >> the >> >> following: >> *https://git-wip-us.apache.org/repos/asf?p=kudu.git;a=commit >> ;h=ffc01ab7238eb08914deccc38beda82e1ec862b5 >> <https://git-wip-us.apache.org/repos/asf?p=kudu.git;a=commit >> ;h=ffc01ab7238eb08914deccc38beda82e1ec862b5>* >> >> The release notes can be found here: >> https://github.com/apache/kudu/blob/1.7.1-RC1/docs/ >> >> release_notes.adoc >> >> >> The KEYS file to verify the artifact signatures can be found here: >> https://dist.apache.org/repos/dist/release/kudu/KEYS >> >> I'd suggest going through the README and the release notes, >> >> building >> >> Kudu, >> >> and running the unit tests. Testing out the Maven repo would also >> >> be >> >> appreciated. >> >> The vote will run until Friday, May 4th at 11PM PDT. >> >> Thank you, >> Grant >> >> -- >> Grant Henke >> Software Engineer | Cloudera >> gr...@cloudera.com | twitter.com/gchenke | >> >> linkedin.com/in/granthenke >> >> >> >> >> >> >> >> >> >> >> >> >> -- >> Todd Lipcon >> Software Engineer, Cloudera >> >> >> *Attila Bukor* | Senior Customer Operations Engineer | Apache Kudu SME >> t. (650) 338-1011 <+16503381011> t. +36 20 2833 421 <+36202833421> e. >> abu...@cloudera.com >> cloudera.com <https://www.cloudera.com> >> >> [image: Cloudera] <https://www.cloudera.com/> >> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: >> Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: >> Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> >> ------------------------------ >> >> > > > -- > Todd Lipcon > Software Engineer, Cloudera Attila Bukor | Senior Customer Operations Engineer | Apache Kudu SME t. (650) 338-1011 <tel:+16503381011> t. +36 20 2833 421 <tel:+36202833421> e. abu...@cloudera.com <mailto:abu...@cloudera.com> cloudera.com <https://www.cloudera.com/> <https://www.cloudera.com/> <https://twitter.com/cloudera> <https://www.facebook.com/cloudera> <https://www.linkedin.com/company/cloudera>
signature.asc
Description: Message signed with OpenPGP
