Wes McKinney has posted comments on this change. Change subject: [python client] - Expand C++ API coverage and improve usability and documentation ......................................................................
Patch Set 6: (6 comments) I updated the Copyright headers as indicated and also added some packaging metadata to make sure the tarball released to PyPI has all the right stuff. This should hopefully be ready to verify and merge. http://gerrit.cloudera.org:8080/#/c/1593/6/python/.gitignore File python/.gitignore: Line 5: # Compiled source > Why do we need to generated and compiled source output given that we're alr In place builds during development, e.g. python setup.py build_ext --inplace Removing some of the unneeded extensions here. http://gerrit.cloudera.org:8080/#/c/1593/6/python/kudu/__init__.py File python/kudu/__init__.py: Line 15: __version__ = '0.1.0' > It's unfortunate that the version is here and in setup.py. Is there any way I added a function in setup.py to auto-generate a version.py so this doesn't have to be manually maintained. http://gerrit.cloudera.org:8080/#/c/1593/6/python/kudu/client.pyx File python/kudu/client.pyx: Line 1034: existing batch. > update this doc done http://gerrit.cloudera.org:8080/#/c/1593/6/python/kudu/compat.py File python/kudu/compat.py: Line 1: # Copyright 2015 Cloudera Inc. > Nit: missing a comma after Cloudera. fixed http://gerrit.cloudera.org:8080/#/c/1593/6/python/kudu/tests/common.py File python/kudu/tests/common.py: Line 1: # Copyright 2015 Cloudera Inc. > Nit: comma here too. fixed http://gerrit.cloudera.org:8080/#/c/1593/6/python/setup.py File python/setup.py: Line 96: author="Wes McKinney", > Should we change author and maintainer_email to reflect team ownership? I went ahead and changed it to reflect Apache Kudu (incubating) team and the dev incubator email list -- To view, visit http://gerrit.cloudera.org:8080/1593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bb98c780f2584f9ad9d301f910d0a5921d5f387 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Wes McKinney <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Martin Grund <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
