Adar Dembo has posted comments on this change.

Change subject: [python client] - Expand C++ API coverage and improve usability 
and documentation
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1593/8/python/setup.py
File python/setup.py:

Line 49:         a = open(filename, 'w')
If open() raises an exception, won't 'a' be undefined in the finally clause?


-- 
To view, visit http://gerrit.cloudera.org:8080/1593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6bb98c780f2584f9ad9d301f910d0a5921d5f387
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Wes McKinney <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Martin Grund <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Wes McKinney <[email protected]>
Gerrit-HasComments: Yes

Reply via email to