Mike Percy has posted comments on this change.

Change subject: Add more thorough instructions for building docs and site
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1581/2/docs/support/scripts/make_site.sh
File docs/support/scripts/make_site.sh:

Line 42: rm -rf "$SOURCE_ROOT/CMakeCache.txt" "$SOURCE_ROOT/CMakeFiles"
> I see. I think it makes more sense to do that (switch your dev environment)
I think it makes sense to support in-tree builds until we have consensus that 
we're ready to enforce out of tree builds. Sorry, I tend to be a late adopter. 
:)

I don't mind adding that comment and removing this if/when we decide to do so.


-- 
To view, visit http://gerrit.cloudera.org:8080/1581
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1cde866d421a96b3803c236333bc1e70ee17f51
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Misty Stanley-Jones <[email protected]>
Gerrit-HasComments: Yes

Reply via email to