Adar Dembo has posted comments on this change. Change subject: Add more thorough instructions for building docs and site ......................................................................
Patch Set 4: -Code-Review (4 comments) http://gerrit.cloudera.org:8080/#/c/1581/4/docs/installation.adoc File docs/installation.adoc: Line 229: . Optional: Install the `asciidoctor` gem if you plan to build documentation. What about this? Seems like it should either be expanded or removed. Line 274: . Optional: Build the documentation. NOTE: This command builds local documentation that This should be removed too. Line 322: . Optional: Install the `asciidoctor` gem and xsltproc if you plan to build documentation. Same here. http://gerrit.cloudera.org:8080/#/c/1581/4/docs/support/scripts/make_site.sh File docs/support/scripts/make_site.sh: Line 43: # Needed for in-tree builds when building in an env that uses ninja. Nit: it's needed for make too, not just ninja. -- To view, visit http://gerrit.cloudera.org:8080/1581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1cde866d421a96b3803c236333bc1e70ee17f51 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Misty Stanley-Jones <[email protected]> Gerrit-HasComments: Yes
