David Ribeiro Alves has posted comments on this change. Change subject: Use 'kqueue' instead of 'select' for the rpc event loop in Mac OS X ......................................................................
Patch Set 1: (2 comments) bq. Not to pick on you, David, but where are we w.r.t. pre-commit tests (or even nightly tests) on a Mac? Is anyone still working on that? that's a good point, we're missing that. I've heard chatter regarding a mac osx build machine but not sure where that stands or if anyone is handling that atm. http://gerrit.cloudera.org:8080/#/c/1897/1/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 75: // When compiling on Mac OS X use 'kqueque' instead of the default, 'select', for the event loop, > Nit: pull this out into a #define switch towards the top of the file, then Done Line 78: : loop_(ev::AUTO), > Why AUTO and not 0? Are they the same? yes they are the same -- To view, visit http://gerrit.cloudera.org:8080/1897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8daa3d02c7e28952eecd9e2ce56cadb8b14c418c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
