Todd Lipcon has posted comments on this change. Change subject: Use 'kqueue' instead of 'select' for the rpc event loop in Mac OS X ......................................................................
Patch Set 2: (1 comment) maybe missed my comments in the previous batch (one of which was identical to adar's) http://gerrit.cloudera.org:8080/#/c/1897/2/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 54: // When compiling on Mac OS X use 'kqueque' instead of the default, 'select', for the event loop, think you missed the typo -- To view, visit http://gerrit.cloudera.org:8080/1897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8daa3d02c7e28952eecd9e2ce56cadb8b14c418c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
