Todd Lipcon has posted comments on this change. Change subject: Spark connectors for Kudu ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/1788/4/java/kudu-spark/src/main/scala/org/kududb/spark/KuduContext.scala File java/kudu-spark/src/main/scala/org/kududb/spark/KuduContext.scala: Line 144: f(it, syncClient, asyncClient) > This is a private method not used anywhere, so I've gone ahead and removed yea, I felt like this class was kinda goofy (not obvious what exactly it does for you that you couldn't do yourself)... hence my suggestion to defer the Spark Streaming stuff to a follow-on commit when we have more time to evaluate the APIs. If it's something we don't anticipate supporting, I think we should either clearly annotate it Unstable, or just not commit it in the first pass (people seem more interested by the RDD/SQL support) -- To view, visit http://gerrit.cloudera.org:8080/1788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic187513ef9724d50024f7401d7ecd19d53554245 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
