Jean-Daniel Cryans has posted comments on this change.

Change subject: Spark connectors for Kudu
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1788/5/java/kudu-spark/src/main/scala/org/kududb/spark/DefaultSource.scala
File java/kudu-spark/src/main/scala/org/kududb/spark/DefaultSource.scala:

Line 86:   @transient lazy val kuduContext = new 
KuduContext(sqlContext.sparkContext, kuduMaster)
The reason the DefaultSourceTest is failing is because this obviously relies on 
having the SQLContext around, which is transient and not always available. This 
line wasn't changed, but the one below used to use the KuduClientCache which 
was creating a client and now it uses the kuduContext's syncClient.

Basically, deserialized KuduRelations used to didn't use kuduContext but now 
they do, and that line is wrong because sqlContext is transient.


-- 
To view, visit http://gerrit.cloudera.org:8080/1788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic187513ef9724d50024f7401d7ecd19d53554245
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to