David Ribeiro Alves has submitted this change and it was merged.

Change subject: Use 'kqueue' instead of 'select' for the rpc event loop in Mac 
OS X
......................................................................


Use 'kqueue' instead of 'select' for the rpc event loop in Mac OS X

It appears that, in Mac OS X, 'select' can't handle connections when 1024 or
more file descriptors are open. This breaks rpc-test consistently and makes
tablet servers crash when serving a lot of/large tablets in OS X.

This patch makes it so we use 'kqueue' in OS X, which doesn't have the same
problem.

I tested this on my local laptop, rpc-test failed before and passes now.

Change-Id: I8daa3d02c7e28952eecd9e2ce56cadb8b14c418c
Reviewed-on: http://gerrit.cloudera.org:8080/1897
Reviewed-by: Todd Lipcon <[email protected]>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/reactor.cc
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/1897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8daa3d02c7e28952eecd9e2ce56cadb8b14c418c
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to