Dan Burkert has posted comments on this change. Change subject: KUDU-980 - Fix timestamp printing in c++ ......................................................................
Patch Set 1: (1 comment) We should try to get this in for the 0.7 release. Timestamps are unusable until this is landed, because the current print routine routinely fails internal CHECKs. http://gerrit.cloudera.org:8080/#/c/965/1/src/kudu/common/types.h File src/kudu/common/types.h: Line 331: static const char* kDateMicrosAndTzFormat = "%s.%06d GMT"; Unless we have a reason otherwise, this should probably be ISO-8601 (should just be changing the date/time separator from ' ' to 'T' and changing the suffix from ' GMT' to 'Z'. -- To view, visit http://gerrit.cloudera.org:8080/965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97eb088a4d0ef082ab9c7e3cca40e809b0f29934 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
