David Ribeiro Alves has posted comments on this change. Change subject: KUDU-980 - Fix timestamp printing in c++ ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/965/1/src/kudu/common/types.h File src/kudu/common/types.h: Line 331: static const char* kDateMicrosAndTzFormat = "%s.%06d GMT"; > Why not just go with the standard, if we already don't match Impala's forma Not totally sure what is best here, on one hand having impala's format is convenient for many reasons but I guess having using a standard would be convinient as well. tell you what I'll post a new patch changing the format in both clients and see what other people think. will keep this patch using the same format as the java client -- To view, visit http://gerrit.cloudera.org:8080/965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97eb088a4d0ef082ab9c7e3cca40e809b0f29934 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
