Dan Burkert has posted comments on this change. Change subject: KUDU-980 - Fix timestamp printing in c++ ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/965/9/src/kudu/common/types-test.cc File src/kudu/common/types-test.cc: Line 58: time = MathLimits<int64>::kMax; kMin is potentially longer because of the negative sign and bigger range, may want to add it as a test case. -- To view, visit http://gerrit.cloudera.org:8080/965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97eb088a4d0ef082ab9c7e3cca40e809b0f29934 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
