Todd Lipcon has posted comments on this change.

Change subject: [python] - Allow to set a lower/upper bound on the scanner
......................................................................


Patch Set 1:

(2 comments)

still curious for your/wes's opinion on the tuple thing mentioned above

http://gerrit.cloudera.org:8080/#/c/2030/1//COMMIT_MSG
Commit Message:

Line 11: XX
> ctrl-X, ctrl-X ctrl-X dammit! :) (nano's exit shortcut)
export EDITOR=vim, man!


http://gerrit.cloudera.org:8080/#/c/2030/1/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 1212:         bint applied
> yes it is (see L 1233 or L 1270). I basically made the old WriteOperation b
ah, OK, a comment indicating that it's set by subclasses would be nice. (this 
is why I dont like implementation inheritance!)


-- 
To view, visit http://gerrit.cloudera.org:8080/2030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7943c913cec957015202ae0d8f8a4add0096fc0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Wes McKinney <[email protected]>
Gerrit-HasComments: Yes

Reply via email to