Wes McKinney has posted comments on this change.

Change subject: [python] - Allow to set a lower/upper bound on the scanner
......................................................................


Patch Set 4: Code-Review+1

I think the current API is OK. How about adding APIs like

scanner.new_bound([('k1', 5), ('k2', 10), ('k3', 'foo')])

and dict-based

scanner.new_bound({'k1': 5, 'k2': 10, 'k3':, 'foo'})

? I don't think this needs to be done in this patch.

-- 
To view, visit http://gerrit.cloudera.org:8080/2030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7943c913cec957015202ae0d8f8a4add0096fc0
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Wes McKinney <[email protected]>
Gerrit-HasComments: No

Reply via email to