Sarah Jelinek has posted comments on this change. Change subject: WIP: refactor cache a bit for contiguous key/value ......................................................................
Patch Set 1: (1 comment) Still need to review more. What I need to know is if you want me to cache the whole cache key I will have to change the nvm cache code. http://gerrit.cloudera.org:8080/#/c/2326/1/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: Line 345: scratch.TryAllocateFromCache(cache, key, ptr.size()); You are only allocating ptr.size() here. And I don't want the whole key structure to be stored in the nvm cache. I want only the the slice.data() portion of this. It looks like you are putting the whole key inside the cache memory. I can change this in the nvm cache but is there a reason you want to do it this way? Unless I am misunderstanding what you are doing. -- To view, visit http://gerrit.cloudera.org:8080/2326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic822d0020431f8d3233034af0cd11c4f2f448a1e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sarah Jelinek <[email protected]> Gerrit-HasComments: Yes
