Sarah Jelinek has posted comments on this change. Change subject: WIP: refactor cache a bit for contiguous key/value ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2326/1/src/kudu/util/cache.cc File src/kudu/util/cache.cc: Line 81: static LRUHandle* from_kv_data(uint8_t* p) { This approach does not work for NVM in persistent mode. That was actually why I had the 'contiguous' flag to tell me how I could free The LRUHandle is allocated from DRAM and the NVM key/value data is allocated from pmem. As a result this has to be managed differently. I have modified nvm_cache.cc to account for the case of NVM in persistent mode. -- To view, visit http://gerrit.cloudera.org:8080/2326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic822d0020431f8d3233034af0cd11c4f2f448a1e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sarah Jelinek <[email protected]> Gerrit-HasComments: Yes
