David Ribeiro Alves has posted comments on this change. Change subject: KUDU-969. Fix handling of crashes just before tablet metadata flush ......................................................................
Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/2333/4//COMMIT_MSG Commit Message: Line 12: rowsets missing closing parens http://gerrit.cloudera.org:8080/#/c/2333/4/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 45: return 100000 * (i % 3) + i; 100k seems low, are we sure the key space ranges won't intersect? Line 160: class UpdaterThreads { would it be hard to add some deletes in this test somewhere? http://gerrit.cloudera.org:8080/#/c/2333/4/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 274: of _the_ data stores... Line 1395: << " that was not active. " xs nit: can merge the line below with this one Line 1410: Either the mutation was duplicated before the metadata : // was flushed hum this is weird. it was always duplicated before the metadata flush, we might have crashed before or after it, right? Line 1472: flushed this is weird. we write/flush the tablet metadata as a whole. we don't flush a drs to the tablet metadata, right? -- To view, visit http://gerrit.cloudera.org:8080/2333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d996a470b9a7957ad3eb7fe02f22f85c32b5f9d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
