Todd Lipcon has posted comments on this change. Change subject: KUDU-969. Fix handling of crashes just before tablet metadata flush ......................................................................
Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/2333/4//COMMIT_MSG Commit Message: Line 12: rowsets > missing closing parens Done http://gerrit.cloudera.org:8080/#/c/2333/4/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 45: return 100000 * (i % 3) + i; > 100k seems low, are we sure the key space ranges won't intersect? changed to 100M Line 160: class UpdaterThreads { > would it be hard to add some deletes in this test somewhere? yea deletes make it harder because the threads have to coordinate with each other not to delete a row that another thread's trying to update (we'd have to add locking, etc). Updates have the nice property that you can just spray them randomly, and if anything got mis-ordered the ksck at the end would figure it out http://gerrit.cloudera.org:8080/#/c/2333/4/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: Line 274: > of _the_ data stores... Done Line 1395: << " that was not active. " > xs nit: can merge the line below with this one Done Line 1410: Either the mutation was duplicated before the metadata : // was flushed > hum this is weird. it was always duplicated before the metadata flush, we m changed to say "arrived" instead of "was duplicated" Line 1472: flushed > this is weird. we write/flush the tablet metadata as a whole. we don't flus yea, changed to say "haven't yet flushed the TabletMetadata update that includes it" -- To view, visit http://gerrit.cloudera.org:8080/2333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d996a470b9a7957ad3eb7fe02f22f85c32b5f9d Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
