Dan Burkert has posted comments on this change. Change subject: Fix gcov weak symbol declaration on OS X ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2494/2/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: Line 41: #ifndef COVERAGE_BUILD > Would you mind inverting this and switching the order of the extern declara Done Line 42: // OS X does not support weak linking properly. > Is there an LLVM bug we can link to? Do we know what the underlying issue i It's not a bug, it's just how weak linking on OS X works. It's a runtime-only thing, using it still requires that the symbol be defined when linking (but not while dynamic linking). Line 45: extern "C" void __gcov_flush() __attribute__((weak_import)); > But this code path works? That is, you tried building a coverage build on O correct. -- To view, visit http://gerrit.cloudera.org:8080/2494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03be748427c9a811ae8fbcb208b077be8a8d9db6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
