Dan Burkert has posted comments on this change. Change subject: Fix gcov weak symbol declaration on OS X ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2494/2/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: Line 45: extern "C" void __gcov_flush() __attribute__((weak_import)); > if it's a coverage build, you shouldn't need weak_import, right? just a nor the weak_import isn't necessary, except that clang then warns about the conditionals always being true. Seemed like an easy way get those to stop. -- To view, visit http://gerrit.cloudera.org:8080/2494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03be748427c9a811ae8fbcb208b077be8a8d9db6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
