Hello Mike Percy, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2510
to review the following change.
Change subject: client-test: fix several sources of TestScanFaultTolerance
flakiness
......................................................................
client-test: fix several sources of TestScanFaultTolerance flakiness
This fixes a couple of flakes that were seen in this test:
1) sometimes we would scan the tablet and end up scanning a minority replica
that hadn't yet replicated the inserts made at the beginning of the test.
This changes to using only two replicas, so that the majority is 2/2 and
we are much more likely to see the writes as soon as the test starts.
It's still not a hard guarantee, because we lack all the features for
proper cross-server consistency, but after looping many times I didn't
see this failure pop up after this fix.
2) fixes MiniTabletServer so that if we Shutdown() and then Start() a server,
it will still retain its old bound port numbers. This fixes a source of
flakiness where, when we restarted a server, it would come back with a
different port, and then be inaccessible for the rest of the test, due to
bugs in the client's handling of host/port changes (KUDU-418).
I have a sense that this will also fix some other flaky tests that relied
on similar shutdown/start sequences.
With this patch, the test case passed 498/500 in ASAN. The remaining two
failures were due to KUDU-1369. Without the patch, I couldn't reproduce
the flakiness easily on GCE machines, but investigating the logs from the
flaky test dashboard make me think this should fix it.
Change-Id: I775a597d396ecdc43ebe826240a77245957070ea
---
M src/kudu/client/client-test.cc
M src/kudu/tserver/mini_tablet_server.cc
2 files changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/2510/1
--
To view, visit http://gerrit.cloudera.org:8080/2510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I775a597d396ecdc43ebe826240a77245957070ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
