Adar Dembo has posted comments on this change. Change subject: client-test: fix several sources of TestScanFaultTolerance flakiness ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2510/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 951: const int kNumReplicas = 2; Two replicas is atypical, so perhaps add a comment here explaining why you're doing it? http://gerrit.cloudera.org:8080/#/c/2510/1/src/kudu/tserver/mini_tablet_server.cc File src/kudu/tserver/mini_tablet_server.cc: Line 93: opts_.webserver_opts.port = bound_http_addr().port(); And add a comment here explaining why we're doing it? -- To view, visit http://gerrit.cloudera.org:8080/2510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I775a597d396ecdc43ebe826240a77245957070ea Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
