Harsh J has posted comments on this change. Change subject: Add Kudu Flume sink. ......................................................................
Patch Set 13: (1 comment) Thank you for addressing my comments! Just one more comment from me that I think was not addressed yet. +0 otherwise from me (not a regular here, cannot +1, will defer to Mike/others) http://gerrit.cloudera.org:8080/#/c/2600/13/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java File java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java: Line 175: return Status.READY; This still needs to be changed to BACKOFF I think, as Mike confirmed in an earlier comment at http://gerrit.cloudera.org:8080/#/c/2600/2/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java@169 -- To view, visit http://gerrit.cloudera.org:8080/2600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e02580908ba2468b216543719ebe5011a267c3 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ara Ebrahimi <[email protected]> Gerrit-Reviewer: Harsh J <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
