Mike Percy has posted comments on this change. Change subject: Add Kudu Flume sink. ......................................................................
Patch Set 15: (3 comments) Noticed a couple of naming nits I have. Nothing major, but let's get these into the first version so we don't have to commit incompatible changes. http://gerrit.cloudera.org:8080/#/c/2600/15/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java File java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java: Line 51: * <tt>master: </tt> The Kudu master host addresses. <p> Please update these when you update the config param names http://gerrit.cloudera.org:8080/#/c/2600/15/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSinkConfigurationConstants.java File java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSinkConfigurationConstants.java: Line 35: public static final String MASTER_ADDRESS = "master"; How about masterAddresses. Mention that this is a comma-separated list of "host:port" pairs of the masters (port optional) Line 40: public static final String TABLE = "table"; How about tableName -- To view, visit http://gerrit.cloudera.org:8080/2600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e02580908ba2468b216543719ebe5011a267c3 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ara Ebrahimi <[email protected]> Gerrit-Reviewer: Harsh J <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
