Adar Dembo has posted comments on this change.

Change subject: Change row projector schema equality check to use physical 
column type
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

It's been ages since I looked at the codegen code, so I'll defer to Todd.

http://gerrit.cloudera.org:8080/#/c/2672/2//COMMIT_MSG
Commit Message:

Line 10: keys, but using the type when comparing projections, resulting in 
spurious debug
Nit: may be clearer if you provide more context for "physical type" above and 
"type" here.


-- 
To view, visit http://gerrit.cloudera.org:8080/2672
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e9a8d9c003be3942d3ce6f93d880adb45d8ded6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to