Jean-Daniel Cryans has posted comments on this change. Change subject: java client: Expose count of error buffer overflows ......................................................................
Patch Set 1: (2 comments) IIRC the c++ client works like the java one, you planning on making the same change there? http://gerrit.cloudera.org:8080/#/c/2840/1/java/kudu-client/src/main/java/org/kududb/client/RowErrorsAndOverflowStatus.java File java/kudu-client/src/main/java/org/kududb/client/RowErrorsAndOverflowStatus.java: Line 26: @InterfaceStability.Evolving > I don't think it really hurts to leave it. If we were going to remove it, I Yeah we do have to deprecate. Line 54: * @return The number of row errors that were discarded, if any. javadoc nit: minor case to start, no period at the end. -- To view, visit http://gerrit.cloudera.org:8080/2840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ee0151c4627f1b7666c512b1de58aff65d81237 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
