Jean-Daniel Cryans has posted comments on this change.

Change subject: java client: Expose count of error buffer overflows
......................................................................


Patch Set 1:

> > (2 comments)
 > >
 > > IIRC the c++ client works like the java one, you planning on
 > making
 > > the same change there?
 > 
 > How about Python then? :) You are right but I'm not planning on
 > doing the c++ client at the moment. But I could spend some time
 > doing it at some point

Well yeah, that's our life now :) If you're not planning on doing, I think you 
should at least doc it in a jira, and if you feel fancy you can add that jira 
in a TODO comment in the C++ code. Background flush doesn't exist in the C++ 
client, so it's not like it's urgent to address.

-- 
To view, visit http://gerrit.cloudera.org:8080/2840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ee0151c4627f1b7666c512b1de58aff65d81237
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-HasComments: No

Reply via email to