David Ribeiro Alves has posted comments on this change. Change subject: lock_manager: add better tracing for slow lock acquisition ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2868/1/src/kudu/tablet/lock_manager.cc File src/kudu/tablet/lock_manager.cc: Line 354: TRACE_COUNTER_INCREMENT("lock_manager_waits", 1); hum can you come up with a better name than lock_manager_waits? seems a bit ambiguous Line 355: MicrosecondsInt64 start_wait = GetMonoTimeMicros(); nit: for consistency "start_wait_us" -- To view, visit http://gerrit.cloudera.org:8080/2868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I133f496bfe8e85128471fc151001a7dab5da4eff Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
