Todd Lipcon has submitted this change and it was merged.

Change subject: lock_manager: add better tracing for slow lock acquisition
......................................................................


lock_manager: add better tracing for slow lock acquisition

This can help diagnose performance issues due to row lock contention.
I was just helping a user who was accidentally inserting a lot of
duplicate primary keys, which resulted in high contention on those
row locks.

This was somewhat evident from the 'prepare_run_time_us' histogram
metric, but would have been more obvious with some request counters
showing the amount of time spent blocked on locks.

No new test since this is just trace instrumentation.

Change-Id: I133f496bfe8e85128471fc151001a7dab5da4eff
Reviewed-on: http://gerrit.cloudera.org:8080/2868
Reviewed-by: David Ribeiro Alves <[email protected]>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/lock_manager.cc
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/2868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I133f496bfe8e85128471fc151001a7dab5da4eff
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to