Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Add a method to return rows in order ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2951/2/java/kudu-client/src/main/java/org/kududb/client/AbstractKuduScannerBuilder.java File java/kudu-client/src/main/java/org/kududb/client/AbstractKuduScannerBuilder.java: Line 74: * WARNING: for advanced users only and can be removed at any time. This method sets the scanner > "This method sets the scanner to return all rows in a tablet in lexicograph I was trying to avoid talking about tablets since it's an implementation detail. Worried folks might start thinking they are wiser than they are :P Line 75: * to return rows in lexicographical order. It will generally be slower than an unsorted scanner. > I'm not sure this really qualifies as "unsafe". It's not going to cause a But it might disappear at any time, will break your code, etc. It's one more "Do Not Cross" line. Line 81: public S unsafeSortResultsByPrimaryKey() { > What are we going to do when we do eventually implement scanner fault toler Rename this method with isFaultTolerant. http://gerrit.cloudera.org:8080/#/c/2951/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: Line 139: public enum OrderMode { > What's the point of this enum, why not just use the PB equivalent? I started with a public API like above, but you're right it's extra code we don't really need. -- To view, visit http://gerrit.cloudera.org:8080/2951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865e28bddd945111ee159b6f2715a8629b75743b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
