Adar Dembo has posted comments on this change. Change subject: [java client] Add a method to return rows in order ......................................................................
Patch Set 3: > > I recall Adar had some concerns on this, may want to check with > him > > before committing. > > Adar was in favor of having a private method that we'd access via > reflection, which I recall you were being against. > > Personally I'd just push this. I'll reprint my perspective here. As I see it, this new method is public in name only. We're doing our very best to prevent any real users from using it, via interface annotations and method naming. My take: let's ditch this half measure in favor of a full measure, and let's: 1. Make this method package private, and 2. Modify kudu-ts so that whomever needs to call this method does so from within org.kududb.client. I won't lie: it's a hack, but IMHO it's a much better way to prevent "real users" from accidentally calling this new method. My other idea was to make the method fully private and use reflection in kudu-ts to adjust the visibility, but that doesn't appear to have gained any fans. -- To view, visit http://gerrit.cloudera.org:8080/2951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I865e28bddd945111ee159b6f2715a8629b75743b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
