Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ......................................................................
Patch Set 2: Hey Dan .. Thanks for the quick feedback. I have uploaded a new patch set with most of the changes you mentioned. The only pending item is to switch the public APIs to use a "NewInListPredicate" method that I can add to KuduTable. I agree that it would be much simpler and cleaner to do that. I have not made that change as I want to include any feedback that Todd or Adar may have. The other additional stuff in this patch set is the logic to push predicates from the InList (key_util.cc and scan_spec.cc). Thanks! -- To view, visit http://gerrit.cloudera.org:8080/2986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
