Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2986/3/src/kudu/common/wire_protocol.cc File src/kudu/common/wire_protocol.cc: Line 505: vector<void*>* values = arena->NewObject<vector<void*>>(); Hi Guys - I needed some help on fixing this final memory leak that was identified by LSAN. It seems that the memory leak is because of not having clear ownership of this "container" that will hold the in-list values. I feel this should be owned by either ScanSpec or by Scanner so I can control its lifetime and delete it cleanly to avoid the memory leak. Any thoughts on what would be a better approach? On a different note, I have finished making the changes to the client facing API per Dan's earlier comments. I have also cleaned up a lot of stuff that Adar had pointed out (lot of it is now obsolete since there is little to no change to the Value class). I will push a new patch set once this pesky leak is cleared. -- To view, visit http://gerrit.cloudera.org:8080/2986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
