Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. ......................................................................
Patch Set 4: > (29 comments) > > I reviewed the client pieces and only started reviewing the common > stuff. Will finish that in the next iteration. > > > The TSAN failure seems to be something unrelated (perhaps some > config issue in Jenkins?). > > From the console output: > > 17:11:33 isolate: > push(/home/jenkins-slave/workspace/kudu-1/build/tsan/bin/cache-test) > failed: http request failed: Internal Server Error (HTTP 500) > 17:11:33 > 17:11:34 Failed to run isolate > 17:11:34 Traceback (most recent call last): > 17:11:34 File > "/home/jenkins-slave/workspace/kudu-1/build-support/dist_test.py", > line 430, in <module> > 17:11:34 main(sys.argv[1:]) > 17:11:34 File > "/home/jenkins-slave/workspace/kudu-1/build-support/dist_test.py", > line 426, in main > 17:11:34 args.func(p, args) > 17:11:34 File > "/home/jenkins-slave/workspace/kudu-1/build-support/dist_test.py", > line 381, in run_all_tests > 17:11:34 run_isolate(staging) > 17:11:34 File > "/home/jenkins-slave/workspace/kudu-1/build-support/dist_test.py", > line 335, in run_isolate > 17:11:34 '--'] + staging.gen_json_paths()) > 17:11:34 File "/usr/lib/python2.7/subprocess.py", line 540, in > check_call > 17:11:34 raise CalledProcessError(retcode, cmd) > > Looks like some sort of issue submitting the tests to the > distributed test server. Thanks Adar! I will wait for you to finish the remainder of the review before I fix the items you have pointed out. Thx again. -- To view, visit http://gerrit.cloudera.org:8080/2986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I986cb13097f1cf4af2b752f58c4c38f412a6a598 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
