David Ribeiro Alves has posted comments on this change. Change subject: Add a generic retriable rpc class ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3064/7/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 74: virtual bool RetryIfNeeded(const RetriableRpcStatus& result, Server* server) { > hm, does this need to be virtual? same with the other private methods below I moved all methods out-of-line, they'll get more complex with the replay cache stuff -- To view, visit http://gerrit.cloudera.org:8080/3064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa58bdc5656a5d4d9172885a67363f74718a0c8e Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
