Adar Dembo has posted comments on this change. Change subject: Add a generic retriable rpc class ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/3064/10/src/kudu/client/batcher.cc File src/kudu/client/batcher.cc: Line 304: // Put 'this' inside a unique_ptr so that, if the control flow changes, we don't leak. Nit: eh, I think it's self-explanatory; don't need the comment. Line 305: std::unique_ptr<WriteRpc> this_instance(this); Nit: "using std::unique_ptr" at the top, then remove the prefix here? http://gerrit.cloudera.org:8080/#/c/3064/10/src/kudu/rpc/retriable_rpc.h File src/kudu/rpc/retriable_rpc.h: Line 42: // TOOD once we have retry handling on all the RPC merge this with rpc::Rpc. Nit: "all the RPCs" -- To view, visit http://gerrit.cloudera.org:8080/3064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa58bdc5656a5d4d9172885a67363f74718a0c8e Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
