Adar Dembo has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3079/4/src/kudu/rpc/rpc_header.proto File src/kudu/rpc/rpc_header.proto: Line 115: // The (unique) id of the client performing this RPC. Could you describe how "unique" this and the sequence number is? My understanding is that this one is globally unique, but the sequence number is only unique to a particular client, right? Line 125: // The number of times this RPC has been tried. So on the first attempt, is this 0 or 1? Line 163: // Optional to maintain compatibility with older clients. Nit: I think this second sentence is implied and can be removed. -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
