Todd Lipcon has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header ......................................................................
Patch Set 1: (4 comments) oops, meant to send these comments yesterday but forgot to publish http://gerrit.cloudera.org:8080/#/c/3079/1/src/kudu/rpc/rpc_header.proto File src/kudu/rpc/rpc_header.proto: Line 113: // The Id of an RPC along with some information that is useful for execution/garbage collection. should be more specific here that this is about replicated/retriable RPCs (or whatever terminology we pick) Line 125: // The number of times this RPC has been tried. be explicit whether this includes or does not include this attempt (ie is the first attempt '1' or '0'?). Should this be optional and only included on retries? Line 162: // The unique id of this request. again clarify which kind of requests Line 163: // Optional to maintain compatibility with older clients. isn't this also optional in that it won't necessarily be used for requests that are naturally idempotent? -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
