David Ribeiro Alves has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers ......................................................................
Patch Set 2: (1 comment) well that math shouldn't be hard to do, give me a number of clients and reqs/sec and I'll wip up a number. now regarding the to the garbage collection mechanism itself it doensn't seem like its too hard to implement, and even if we decide not to do it right away it doesn't seem like it hurts having support for it in the client's request tracker. http://gerrit.cloudera.org:8080/#/c/3078/2/src/kudu/rpc/request_tracker.cc File src/kudu/rpc/request_tracker.cc: Line 35: if (PREDICT_FALSE(incomplete_rpcs_.size() >= FLAGS_rpc_max_in_flight_linearizable_rpcs)) { > Not quite following (admittedly haven't read the paper in a while). Isn't t K, removed -- To view, visit http://gerrit.cloudera.org:8080/3078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23201625ca02f244dc94205d88dabc01608de471 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
