David Ribeiro Alves has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3078/2/src/kudu/rpc/request_tracker.h File src/kudu/rpc/request_tracker.h: Line 32: // for new rpcs and tracking the ongoing ones. > per the comment on the commit message, I'm worried this is a little confusi Done Line 37: typedef int64_t SeqNo; > hrm, not sure it's worth that much to abbreviate instead of SequenceNumber Done Line 67: simple_spinlock lock_; > better to put the lock first before the fields it protects Done -- To view, visit http://gerrit.cloudera.org:8080/3078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23201625ca02f244dc94205d88dabc01608de471 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
